config: support setting age and PGP keys as a strings array#849
Closed
johanfleury wants to merge 1 commit intogetsops:mainfrom
Closed
config: support setting age and PGP keys as a strings array#849johanfleury wants to merge 1 commit intogetsops:mainfrom
johanfleury wants to merge 1 commit intogetsops:mainfrom
Conversation
Contributor
Author
|
Ok, so I’m not a Go expert and I’m not sure this is the best way to implement this. Unit tests pass locally, but I’d appreciate a review on this before going further. |
Contributor
|
I don't think this is backwards compatible, right? Functional tests are failing because of that. |
Contributor
Author
|
I can’t really tell why the functional tests are failing and when I tried to run them manually (i.e. executing sops with the same args) it seemed to work. I can work on making them pass, but as I said, I’m not sure this is the correct way to implement this so I’ve not focused on that yet. |
Contributor
|
Closing since this now has been implemented in #1880. Thanks a lot for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #845